Keep sub-evaluators up to date after integration step #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-novo
force-pushed
the
add-ida-callbacks
branch
from
0e07a26 to
c4e5e7c
Compare
Evaluators which contain "children" evaluators such as systems should be given the chance to keep their sub-evaluators up to date after events like an integrator step. With the `update()` method, an external source can notify the evaluator when its state has been updated so that it can then go and update its children. This is useful for callbacks, since callbacks will probably want to query individual components rather than systems.
Since other systems could be children in a system, it's important to notify them when they've been updated.
alexander-novo
force-pushed
the
update-system-children
branch
from
9420949 to
7ef877e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evaluators which contain "children" evaluators such as systems should be given the chance to keep their sub-evaluators up to date after events like an integrator step. With the
update()method, an external source can notify the evaluator when its state has been updated so that it can then go and update its children.This is useful for callbacks, since callbacks will probably want to query individual components rather than systems.
Closes #96
Proposed changes
Add a new
update()interface toEvaluatorwhich anyone who updates anEvaluator's state manually (such as integrators) can let theEvaluatorknow that its state has been modified. By default, anEvaluatorwill choose to ignore this notice, butSystems can then update all of their children.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Waiting on #91, which somewhat demonstrates more why we would want this change.